Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add support for PHP 8.4 #1278

Merged
merged 2 commits into from
Oct 28, 2024
Merged

[FEATURE] Add support for PHP 8.4 #1278

merged 2 commits into from
Oct 28, 2024

Conversation

oliverklee
Copy link
Contributor

No description provided.

@oliverklee
Copy link
Contributor Author

Currently blocked by MyIntervals/PHP-CSS-Parser#677.

@oliverklee oliverklee force-pushed the feature/php-84 branch 3 times, most recently from e3076f0 to 41ebf80 Compare August 28, 2024 21:58
@oliverklee oliverklee force-pushed the feature/php-84 branch 2 times, most recently from 6e3cf40 to 2ddd770 Compare September 14, 2024 07:33
@davidrans
Copy link

Is this still blocked? MyIntervals/PHP-CSS-Parser#677 was closed because it was unnecessary

@coveralls
Copy link

coveralls commented Oct 4, 2024

Coverage Status

coverage: 97.062%. remained the same
when pulling 450833c on feature/php-84
into afd7b78 on main.

@oliverklee
Copy link
Contributor Author

Hi @davidrans, thanks for the ping!

Yes, this is still blocked. We'll need to create a new release of PHP-CSS-Parser first.

@oliverklee oliverklee force-pushed the feature/php-84 branch 4 times, most recently from 4eacd15 to 2a0d5f9 Compare October 27, 2024 07:14
@oliverklee
Copy link
Contributor Author

Symfony 4.4 is not compatible with PHP 8.4 due to an explicitly nullable constructor parameter:
https://github.com/symfony/symfony/blob/4.4/src/Symfony/Component/CssSelector/XPath/Translator.php

Symfony 4.4 also won't get any fixes anymore as it reached its EOL in November 2023 according to https://symfony.com/releases.

I propose we skip the unit tests on CI for PHP 8.4 with the lowest dependencies (so we can release version 7.3.0) and drop support for Symfony 4.4 in version 8.0.0.

What do you think, @JakeQZ?

@JakeQZ
Copy link
Contributor

JakeQZ commented Oct 27, 2024

I propose we skip the unit tests on CI for PHP 8.4 with the lowest dependencies (so we can release version 7.3.0) and drop support for Symfony 4.4 in version 8.0.0.

I think that makes sense, and is preferable to dropping Symfony 4.4 support in the same release that supports PHP 8.4 as well as including recent features and fixes. It's possible (though unlikely) that someone might be using PHP 8.4 with a complex set of dependencies that means they need the older Symfony version, but even if so, these are not errors, just deprecation warnings.

@JakeQZ
Copy link
Contributor

JakeQZ commented Oct 27, 2024

I propose we skip the unit tests on CI for PHP 8.4 with the lowest dependencies

PS. I'm not sure how you'd get the GitHub Action matrix shaped like a Tetяis piece...

@oliverklee oliverklee marked this pull request as ready for review October 28, 2024 08:36
@oliverklee oliverklee requested a review from JakeQZ October 28, 2024 08:36
@JakeQZ JakeQZ merged commit 8ec017c into main Oct 28, 2024
26 checks passed
@JakeQZ JakeQZ deleted the feature/php-84 branch October 28, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants