-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Add support for PHP 8.4 #1278
Conversation
85172a5
to
1418bc3
Compare
Currently blocked by MyIntervals/PHP-CSS-Parser#677. |
e3076f0
to
41ebf80
Compare
6e3cf40
to
2ddd770
Compare
Is this still blocked? MyIntervals/PHP-CSS-Parser#677 was closed because it was unnecessary |
2ddd770
to
a77a5d4
Compare
Hi @davidrans, thanks for the ping! Yes, this is still blocked. We'll need to create a new release of PHP-CSS-Parser first. |
4eacd15
to
2a0d5f9
Compare
2a0d5f9
to
3a81ee1
Compare
Symfony 4.4 is not compatible with PHP 8.4 due to an explicitly nullable constructor parameter: Symfony 4.4 also won't get any fixes anymore as it reached its EOL in November 2023 according to https://symfony.com/releases. I propose we skip the unit tests on CI for PHP 8.4 with the lowest dependencies (so we can release version 7.3.0) and drop support for Symfony 4.4 in version 8.0.0. What do you think, @JakeQZ? |
I think that makes sense, and is preferable to dropping Symfony 4.4 support in the same release that supports PHP 8.4 as well as including recent features and fixes. It's possible (though unlikely) that someone might be using PHP 8.4 with a complex set of dependencies that means they need the older Symfony version, but even if so, these are not errors, just deprecation warnings. |
PS. I'm not sure how you'd get the GitHub Action matrix shaped like a Tetяis piece... |
No description provided.